Symfony 8 support follow-up, PHPUnit 11 #678
Open
+189
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kocal
force-pushed
the
symfony-8-support
branch
from
2f9393d to
d6646c1
Compare
Member
Author
|
The CI was already red before this PR btw |
dunglas
force-pushed
the
symfony-8-support
branch
from
d6646c1 to
b00e50c
Compare
Member
Kocal
force-pushed
the
symfony-8-support
branch
from
b00e50c to
9ef85eb
Compare
Kocal
commented
Nov 22, 2025
Member
Author
|
@dunglas PR rebased, I also fixed |
xabbuh
reviewed
Nov 22, 2025
xabbuh
reviewed
Nov 22, 2025
Kocal
force-pushed
the
symfony-8-support
branch
5 times, most recently
from
d488b41 to
6a05d18
Compare
Member
Author
|
Everything is green 🙌🏻 |
xabbuh
reviewed
Nov 27, 2025
Kocal
force-pushed
the
symfony-8-support
branch
from
6a05d18 to
cc37227
Compare
xabbuh
reviewed
Nov 27, 2025
xabbuh
reviewed
Nov 27, 2025
Kocal
force-pushed
the
symfony-8-support
branch
from
cc37227 to
db5316b
Compare
Kocal
changed the title
xabbuh
reviewed
Nov 27, 2025
|
|
||
| <!-- http://phpunit.de/manual/4.1/en/appendixes.configuration.html --> | ||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.0/phpunit.xsd" |
Member
There was a problem hiding this comment.
Suggested change
| xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.0/phpunit.xsd" | |
| xsi:noNamespaceSchemaLocation="vendor/phpunit/phpunit/phpunit.xsd" |
maybe there is more to take from https://github.com/symfony/recipes/blob/main/phpunit/phpunit/11.1/phpunit.dist.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIRC the CI was already broken before this PR